Patch 10 in the glslang-elimination series. The shadergen helper is
named GenerateVRAMReadFragmentShader, but the pipeline it lives in
(m_vram_readback_pipeline) is the CPU readback path: it samples the
upscaled m_vram_texture, runs a box filter to downsample blocks back
to PSX-native 16bpp, and packs two adjacent 16-bit pixels into one
RGBA8 output texel for the host to pick up via staging.
Shader converted:
VRAMReadFragmentShader. Single output slot, no per-frame variance
- the existing C++ side already caches it as a single
m_vram_readback_pipeline VkPipeline. Two blobs only because of the
source texture's MSAA structural split (sampler2D vs sampler2DMS).
Blobs:
vram_readback_fs - sampler2D, no per-pixel sample averaging.
vram_readback_msaa_fs - sampler2DMS, LoadVRAM averages
MULTISAMPLES texelFetch results before
the box filter runs.
Common spec constant:
id = 0 RESOLUTION_SCALE (uint) - drives both the base_coords stride
and the box-filter inner-loop
bounds.
MSAA blob adds:
id = 1 MULTISAMPLES (uint) - LoadVRAM averaging loop bound.
The OpenGL lower-left-origin Y-flip branch in the shadergen source is
omitted: Vulkan VRAM Y matches scanout Y directly, so the conditional
fold-up never fires on this backend. The single output pipeline keeps
its single C++ slot - no per-mode array needed.
Render target (m_vram_readback_texture) is always single-sample at
line 1118, so the pipeline's multisample state stays at the default
single-sample on both blobs. As with display, the MSAA-ness lives
entirely in the input sampler type.
Bindings unchanged: push_constant for the UBO, set=0 binding=1 for
the source sampler, matching m_single_sampler_pipeline_layout.
Smoke tests:
- g++ -fsyntax-only on the touched common TU.
- spirv-val --target-env vulkan1.0 on both blobs (1158 / 1302
words, 4.5K / 5.1K).
- --target-env vulkan1.0 vs un-flagged glslangValidator: byte-
identical SPIR-V for both.
VRAM readback is the rarest of the utility pipelines - it's exercised
only when something reads from upscaled VRAM through the host (save-
state capture, debugger introspection, certain games that read back
their own framebuffer for special effects). Not on the SSAA-toggle
hot-build path; shader_precompile=Disabled is expected to behave
identically to Enabled / Lazy.
Test priority:
- shader_precompile=Enabled / Lazy: routine smoke.
- shader_precompile=Disabled: any savestate save + load round-trip
(forces a readback). A few games also self-read for visual
effects - Silent Hill's fog overlay and the Castlevania:
Symphony of the Night transition flashes are known triggers.
SSAA round-trip is incidental but quick.
After this lands, the only non-batch shaders still on the runtime
shadergen + glslang path are the VRAM update depth pair, which is on
the SSAA-toggle hot-build path and broke patch 5. Plan for those is
to introduce a targeted pre-build at CompilePipelines time even in
Disabled mode, separately from the SPIR-V conversion itself.