msvc: enable minimal debug info for release builds

build: supply pdb file with msvc build

.github/workflows/build.yml

@@ -80,7 +80,9 @@ jobs:
         uses: actions/upload-artifact@v3
         with:
           name: ${{env.name}}
-          path: ${{env.name}}/yapb.dll
+          path: |
+            ${{env.name}}/yapb.dll
+            ${{env.name}}/yapb.pdb
 
   bot-release:
     if: |

meson.build

@@ -195,13 +195,13 @@ elif os == 'windows' and (cxx =='msvc' or cxx == 'clang-cl')
    # minor optimizations for release build
    if build_type == 'release'
       cxxflags += [
-         '/GS-', '/Ob2', '/Oy', '/Oi', '/Ot', '/fp:precise', '/GF', '/GS-', '/GF', '/arch:SSE2'
+         '/GS-', '/Ob2', '/Oy', '/Oi', '/Ot', '/fp:precise', '/GF', '/GS-', '/GF', '/arch:SSE2', '/Zi'
       ]
 
       # add wpo if msvc
       if cxx == 'msvc'
          cxxflags += [
-            '/GL'
+            '/GL', '/DEBUG'
          ]
       endif
 

vc/yapb.vcxproj

@@ -250,7 +250,7 @@
       <ProgramDataBaseFileName>.\release\inf\</ProgramDataBaseFileName>
       <WarningLevel>Level4</WarningLevel>
       <SuppressStartupBanner>true</SuppressStartupBanner>
-      <DebugInformationFormat>None</DebugInformationFormat>
+      <DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
       <CompileAs>CompileAsCpp</CompileAs>
       <InterproceduralOptimization>MultiFile</InterproceduralOptimization>
       <FlushDenormalResultsToZero>true</FlushDenormalResultsToZero>
@@ -285,7 +285,7 @@
       <OutputFile>.\release\yapb.dll</OutputFile>
       <SuppressStartupBanner>true</SuppressStartupBanner>
       <DelayLoadDLLs>user32.dll;ws2_32.dll;%(DelayLoadDLLs)</DelayLoadDLLs>
-      <GenerateDebugInformation>false</GenerateDebugInformation>
+      <GenerateDebugInformation>true</GenerateDebugInformation>
       <GenerateMapFile>false</GenerateMapFile>
       <SubSystem>Windows</SubSystem>
       <OptimizeReferences>true</OptimizeReferences>