fix: startup on hlds_l 3111e (still needs nosmid)

build: add option to build bot without any smid instructions
refactor: fix static analyzer warnings
crlib: update submodule (fix double anglevectors call)

inc/graph.h

@@ -100,19 +100,19 @@ struct PODGraphHeader {
 
 // defines linked nodes
 struct PathLink {
-   Vector velocity;
-   int32_t distance;
-   uint16_t flags;
-   int16_t index;
+   Vector velocity {};
+   int32_t distance {};
+   uint16_t flags {};
+   int16_t index {};
 };
 
 // define graph path structure for yapb
 struct Path {
-   int32_t number, flags;
-   Vector origin, start, end;
-   float radius, light, display;
-   PathLink links[kMaxNodeLinks];
-   PathVis vis;
+   int32_t number {}, flags {};
+   Vector origin {}, start {}, end {};
+   float radius {}, light {}, display {};
+   PathLink links[kMaxNodeLinks] {};
+   PathVis vis {};
 };
 
 // define waypoint structure for podbot (will convert on load)

inc/storage.h

@@ -11,7 +11,7 @@
 constexpr char kPodbotMagic[8] = { 'P', 'O', 'D', 'W', 'A', 'Y', '!', kNullChar };
 
 constexpr int32_t kStorageMagic = 0x59415042; // storage magic for yapb-data files
-constexpr int32_t kStorageMagicUB = 0x544f4255; //support also the fork format (merged back into yapb)
+constexpr int32_t kStorageMagicUB = 0x544f4255; // support also the fork format (merged back into yapb)
 
 // storage header options
 CR_DECLARE_SCOPED_ENUM (StorageOption,

inc/yapb.h

@@ -39,13 +39,13 @@ public:
 
 // weapon properties structure
 struct WeaponProp {
-   String classname;
-   int ammo1; // ammo index for primary ammo
-   int ammo1Max; // max primary ammo
-   int slot; // HUD slot (0 based)
-   int pos; // slot position
-   int id; // weapon ID
-   int flags; // flags???
+   String classname {};
+   int ammo1 {}; // ammo index for primary ammo
+   int ammo1Max {}; // max primary ammo
+   int slot {}; // HUD slot (0 based)
+   int pos {}; // slot position
+   int id {}; // weapon ID
+   int flags {}; // flags???
 };
 
 // weapon info structure
@@ -89,23 +89,23 @@ public:
 
 // clients noise
 struct ClientNoise {
-   Vector pos;
-   float dist;
-   float last;
+   Vector pos {};
+   float dist {};
+   float last {};
 };
 
 // array of clients struct
 struct Client {
-   edict_t *ent; // pointer to actual edict
-   Vector origin; // position in the world
-   int team; // bot team
-   int team2; // real bot team in free for all mode (csdm)
-   int flags; // client flags
-   int radio; // radio orders
-   int menu; // identifier to opened menu
-   int iconFlags[kGameMaxPlayers]; // flag holding chatter icons
-   float iconTimestamp[kGameMaxPlayers]; // timers for chatter icons
-   ClientNoise noise;
+   edict_t *ent {}; // pointer to actual edict
+   Vector origin {}; // position in the world
+   int team {}; // bot team
+   int team2 {}; // real bot team in free for all mode (csdm)
+   int flags {}; // client flags
+   int radio {}; // radio orders
+   int menu {}; // identifier to opened menu
+   int iconFlags[kGameMaxPlayers] {}; // flag holding chatter icons
+   float iconTimestamp[kGameMaxPlayers] {}; // timers for chatter icons
+   ClientNoise noise {};
 };
 
 // think delay mapping